Fixes #25057 - Sort hosts bulk actions #6095
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 27, 2018
app/helpers/hosts_helper.rb
Outdated
| @@ -177,7 +177,7 @@ def multiple_actions | |||
|
|
|||
| def multiple_actions_select | |||
| select_action_button(_("Select Action"), {:id => 'submit_multiple'}, | |||
| multiple_actions.map do |action| | |||
| multiple_actions.sort_by{|action| action[0]}.map do |action| | |||
There was a problem hiding this comment.
Layout/SpaceBeforeBlockBraces: Space missing to the left of {.
|
Issues: #25057 |
sbernhard
force-pushed
the
sort_actions
branch
from
5a2a83e
to
0d46a8f
Compare
|
thanks for the patch, note that there was already some work and discussion at which implements the same thing just slightly differently - #4497 |
|
Well, for current form of the patch, the same outcome applies I think. Without grouping, this might be even worse as actions that logically belongs together, will be misordered. If you think this is not an issue, I'd recommend suggesting that in the original PR. If majority is for alphabetical order, we can merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.