fixes #2498 FactNames are not precreated #615
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. It would be nice to avoid the find_or_create_by_name multiple lookups if possible, but this should still be merged even if we can't avoid it - its a significant increase in performance. |
| @@ -85,18 +85,13 @@ def merge_facts(facts) | |||
| fact_names = FactName.where(:name => facts.keys) | |||
|
|
|||
There was a problem hiding this comment.
Doesn't look like fact_names is being used anymore...
|
@witlessbird 's fix showed an speed improvement of 5-10%, so I updated the pull request |
|
@elobato Thanks for spending your time on profiling this! |
|
@elobato can you please squash the commits? |
Witlessbird's fix to reduce database lookups and do Ruby hash lookups instead
|
@skottler done! |
| next if db_facts.include?(fact_name.name) | ||
| value = facts[fact_name.name] | ||
| facts.each do |name, value| | ||
| next if db_facts.include?(name) |
There was a problem hiding this comment.
instead of comparing each run, cant we also optimize it, e.g. something in the spirit of:
(facts.keys - db_facts).each do |name|
value = facts[name]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
facts.keys.dup.delete_if { |n| fact_names.map(&:name).include? n } creates a tremendous overhead on the facts import from the puppet masters, this fix simply takes the code from the original Puppet::Rails::Host. As an example, imports have gone from ~30s to ~200ms