Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #25271 - add current-org's id to redux store #6164

Merged
merged 1 commit into from Oct 23, 2018
Merged

Fixes #25271 - add current-org's id to redux store #6164

merged 1 commit into from Oct 23, 2018

Conversation

amirfefer
Copy link
Member

@amirfefer amirfefer commented Oct 22, 2018 •
edited

The store contains org title, but no id. Which is require in some circumstances.

@coveralls
Copy link

coveralls commented Oct 23, 2018 •
edited

Coverage Status

Coverage increased (+0.08%) to 75.615% when pulling 7bc6310 on amirfefer:25271 into abc30c6 on theforeman:develop.

sharvit
sharvit approved these changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@sharvit sharvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @amirfefer 👍

@ohadlevy
Copy link
Member

[test foreman]

@ohadlevy
Copy link
Member

test failures not related, thanks @amirfefer

@ohadlevy ohadlevy merged commit c74c4df into theforeman:develop Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohadlevy ohadlevy ohadlevy approved these changes

@sharvit sharvit sharvit approved these changes

Assignees
No one assigned
Labels
Needs testing UI
Projects
None yet
Milestone
No milestone
5 participants
@amirfefer @coveralls @ohadlevy @sharvit @theforeman-bot