Fixes #23699 - Remediation Support for Host Status #6167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #23699 |
|
Sorry for two PRs but first PR automatically closed while Github was down. |
|
Hello, @ares I am having one more doubt regarding taking this method to status.rb file. I moved this method as like to_label but is it Ok to make the method remediation_help_text as self method in build_status.rb file and should we pass any parameter to this method? as the method is now defined in both status.rb and build_status.rb file returning nil and string respectively. But now there is no object of class from build_status.rb that I can access in view, so should I make this method a class method? |
akshay-mendhe
force-pushed
the
remediation_support_host_status
branch
from
db11e63
to
179e949
Compare
houndci-bot
reviewed
Oct 24, 2018
app/models/host_status/status.rb
Outdated
| @@ -72,6 +72,10 @@ def update_timestamp | |||
| def update_status | |||
| self.status = to_status | |||
| end | |||
|
|
|||
| def remediation_help_text | |||
| return nil | |||
There was a problem hiding this comment.
Style/RedundantReturn: Redundant return detected.
akshay-mendhe
force-pushed
the
remediation_support_host_status
branch
2 times, most recently
from
a474886
to
5780973
Compare
akshay-mendhe
force-pushed
the
remediation_support_host_status
branch
from
5780973
to
b377dca
Compare
akshay-mendhe
force-pushed
the
remediation_support_host_status
branch
from
b377dca
to
dd81355
Compare
|
Closing in favor of GH-6692, thanks @akshay-mendhe ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.