Fixes #25168 - add managed icon interface overview #6183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #25168 |
akshay-mendhe
force-pushed
the
add_managed_interface_icon
branch
3 times, most recently
from
4da55f9
to
2b90bbf
Compare
akshay-mendhe
force-pushed
the
add_managed_interface_icon
branch
3 times, most recently
from
370cf9a
to
0a5dbd7
Compare
apuntamb
reviewed
Nov 27, 2018
| @@ -276,6 +284,15 @@ $(document).on('click', '.provision-flag', function () { | |||
| update_interface_table(); | |||
| }); | |||
|
|
|||
| $(document).on('click', '.managed-flag', function onClickManaged() { | |||
There was a problem hiding this comment.
Can we use a single function for all three: primary, managed and provisioning with the interface-ids being updated inside if-else ?
akshay-mendhe
force-pushed
the
add_managed_interface_icon
branch
5 times, most recently
from
e37f70e
to
42f05a4
Compare
akshay-mendhe
force-pushed
the
add_managed_interface_icon
branch
from
42f05a4
to
8a6c842
Compare
|
Closing in favor of GH-6689, thanks @akshay-mendhe ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.