Fixes #25451 - Make certificate loading robust #6239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 13, 2018
|
I tested this code change on nightly and the puppet bats tests passed. So if unit tests are happy, I think this is good by me and the WIP can be dropped. |
ekohl
force-pushed
the
robust-cert-loading
branch
from
5688520
to
191cba7
Compare
ekohl
changed the title
ekohl
force-pushed
the
robust-cert-loading
branch
from
191cba7
to
20d7f8c
Compare
|
I've added some tests, created an issue and dropped the WIP. Ready for review now. |
|
Two test classes in a single file aren't the rails way (at least with my limited understanding). I would have used two |
This is copied from Katello's app/services/cert/rhsm_client.rb with added tests.
ekohl
force-pushed
the
robust-cert-loading
branch
from
20d7f8c
to
8e5ae2f
Compare
|
I agree this looks cleaner. |
timogoebel
approved these changes
Nov 14, 2018
|
Thanks, @ekohl. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is copied from Katello's app/services/cert/rhsm_client.rb which should probably be merged in a cleaner way.