Fixes #25492 - Remove the :login setting #6259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #25492 |
ekohl
reviewed
Nov 18, 2018
app/registries/menu/loader.rb
Outdated
| menu.item :roles, :caption => N_('Roles') | ||
| end | ||
| menu.item :auth_source_ldaps, :caption => N_('LDAP Authentication') | ||
| menu.item :users, :caption => N_('Users') |
There was a problem hiding this comment.
Nit: would be nice to keep alignment
|
Needs a rebase, refactoring needs to be all green. |
lzap
previously approved these changes
Nov 20, 2018
|
@lzap fixed the failing tests, all 🍏 now |
|
@tbrisker do you also track installer changes? Probably this needs to be removed from there as well. |
|
Since we always maintain compatibility with older versions (typically n - 2), I'm leaning to not making a change. Foreman will ignore the unused setting and we should remember to remove it when we drop support for 1.20. |
|
installer side is at theforeman/puppet-foreman#690 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.