Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #25648 - Delete filters as system admin #6330

Merged
merged 1 commit into from Dec 21, 2018

Conversation

Projects
None yet
4 participants
@xprazak2
Copy link
Contributor

commented Dec 13, 2018

No description provided.

@theforeman-bot

This comment has been minimized.

Copy link
Member

commented Dec 13, 2018

Issues: #25648

@san7ket
Copy link

left a comment

As a system admin, I was able to delete the filter on role successfully

@tbrisker tbrisker requested a review from ares Dec 16, 2018

@@ -69,7 +69,7 @@ def find_role

def resource_base
@resource_base ||= if @role.present?
@role.filters.authorized(current_permission)
Filter.authorized_as(User.current, current_permission)

This comment has been minimized.

Copy link
@ares

ares Dec 18, 2018

Member

as suggested on IRC, Filter.authorized(current_permission) would be nicer if it works

@xprazak2

This comment has been minimized.

Copy link
Contributor Author

commented Dec 20, 2018

Changed, Filter.authorized(current_permission) worked for me.

@ares

ares approved these changes Dec 21, 2018

@ares

This comment has been minimized.

Copy link
Member

commented Dec 21, 2018

Thanks @xprazak2, merging!

@ares ares merged commit 65f476e into theforeman:develop Dec 21, 2018

6 of 7 checks passed

katello Build finished. 4118 tests run, 9 skipped, 1 failed.
Details
Hound No violations found. Woof!
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
foreman Build finished. 36117 tests run, 15 skipped, 0 failed.
Details
prprocessor Commit message style is correct
Details
upgrade Build finished. No test results found.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.