Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #25693 - Update fallback config for i18n 1.1 gem #6336

Merged
merged 1 commit into from Jan 6, 2019
Merged

Fixes #25693 - Update fallback config for i18n 1.1 gem #6336

merged 1 commit into from Jan 6, 2019

Conversation

mmoll
Copy link
Contributor

@mmoll mmoll commented Dec 14, 2018

No description provided.

@theforeman-bot
Copy link
Member

Issues: #25693

@mmoll
Copy link
Contributor Author

mmoll commented Dec 14, 2018

If this finds approval, I'd open an update for i18n to 1.2.0 for RPMs. The alternative would be to pin it to 1.0.x.

@mmoll
Copy link
Contributor Author

mmoll commented Dec 14, 2018

See ruby-i18n/i18n#442

@mmoll
Copy link
Contributor Author

mmoll commented Dec 14, 2018

[test upgrade]

Copy link
Member

@tbrisker tbrisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@mmoll
Copy link
Contributor Author

mmoll commented Dec 17, 2018

RPM PR: theforeman/rails-packaging#150

I guess this change should also go into 1.20 then?

@tbrisker
Copy link
Member

for 1.20 i think it's better to pin for debians (i assume that rpms are on 1.0 anyways?)

@mmoll
Copy link
Contributor Author

mmoll commented Dec 18, 2018

@ehelms @ekohl Is the Rails 5.2 repo shared across Foreman versions?

@ohadlevy ohadlevy added the Waiting on Packaging PRs that shouldn't be merged until packaging side is merged label Dec 25, 2018
@ekohl
Copy link
Member

ekohl commented Dec 25, 2018

@mmoll no, we have split them per version: https://yum.theforeman.org/rails/

@mmoll
Copy link
Contributor Author

mmoll commented Dec 25, 2018

OK, then I think this should go into develop and the RPM PR merged, I'll take care of pinning i18n in older DEB builds then.

Copy link
Member

@tbrisker tbrisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mmoll !

@tbrisker tbrisker merged commit 11bfc14 into theforeman:develop Jan 6, 2019
@mmoll mmoll deleted the i18n_11 branch January 6, 2019 11:32
@tbrisker
Copy link
Member

@mmoll did you pin this for 1.20 debians? we're planning to do 1.20.2 this week

@mmoll
Copy link
Contributor Author

mmoll commented Feb 11, 2019

@tbrisker Could we pin this in the -stable branch itself (<1.1)?

@tbrisker
Copy link
Member

tbrisker commented Feb 11, 2019

@mmoll sure, works for me. rpm uses scl which has 1.0.1 for 1.20 anyways.

@mmoll
Copy link
Contributor Author

mmoll commented Feb 11, 2019

done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs testing Waiting on Packaging PRs that shouldn't be merged until packaging side is merged
Projects
None yet
5 participants