Fixes #25543 - Breadcrumb switcher doesn't work for filters

[MariaAga]

When editing a filter /filters/<id>/edit, the breadcrumb-switcher showed blank lines in the results box.
Also changed breadcrumbs in filters from "filters > filter" to "Roles > role Filters
Edit filter Filter" since filters are a part of roles and aren't a standalone.

[theforeman-bot]

Do not merge! This patch has not been tested yet.

Can an existing organization member please verify this patch?

[theforeman-bot]

Do not merge! This patch has not been tested yet.

Can an existing organization member please verify this patch?

[theforeman-bot]

Do not merge! This patch has not been tested yet.

Can an existing organization member please verify this patch?

[theforeman-bot]

Issues: #25543

[theforeman-bot]

There were the following issues with the commit message:

• 15183be must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.

---

This message was auto-generated by Foreman's prprocessor

[tbrisker]

ok to test

[amirfefer]

Thanks @MariaAga !
I left few inline comments :)

[amirfefer]

Thanks @MariaAga !
Test failures are related

[coveralls]

Coverage remained the same at 69.565% when pulling ea656e1 on MariaAga:25543 into 98974ec on theforeman:develop.

[coveralls]

Coverage remained the same at 72.666% when pulling 57d8953 on MariaAga:25543 into 0b5fef8 on theforeman:develop.

[mmoll]

@MariaAga please fix the rubocop violation

[ekohl]

I'm still not sure if we should be using translated values here. In my experience having a simple model which is nil or an actual value is better. Then when you need to present it to the user, you actually ensure there's a good value. A helper for this (like display_resource_type) can make sense. Converting from a presentation value back to an actual value is a recipe for problems that are hard to trace back.

[MariaAga]

@ekohl can you take a look? It is now only translated when the value is presented

[sharvit]

@ekohl can you have a look please?

[MariaAga]

Test failures are unrelated.

@tbrisker I addressed all of your comments, could you please take another look?

@ekohl I fixed the translations.

[ekohl]

I'm still not sure about magic strings, just that my computer science professor would fail me if I tried to use them. Generally they're very fragile because you can't really trace the data flow. Adding translations into the mix just screams for bugs. I don't know the code base well enough to say anything useful about whether it would break but only translating it in the presentation (views) is usually the correct way.

[MariaAga]

@ekohl, instead of all the string handling I added a field resource_type_label to be passed to the breadcrumbs and view. Thanks for the feedback!

[ekohl]

This looks like the correct approach Small questions but no objections to merging.

[xprazak2]

What is the status here?

[ekohl]

@xprazak2 I think this is ready for merge, but would prefer someone else to do a final review and merge it.

[xprazak2]

Works well, I just left one inline comment. After that, I think we can merge.

[xprazak2]

@tbrisker, @ares, any additional comments?

[tbrisker]

Looks like my comments were addressed. Did not test again.

[xprazak2]

Thanks everyone!