Fixes #25894 - rename the host statuses report

[ares]

Reproducing steps:

1. go to monitor -> report templates
2. host statuses contains format in name, see "CSV"

this is no longer needed, we use rendering DSL which can modify the type, this is a leftover

to review:

3. apply the patch, run rake db:migrate
4. run rake db:seed
5. go to page from 2) see the name has changed, metadata also changed (thanks to seed) so the name is correct there
6. the template id hasn't changed, no audit was created for this internal change

Best with theforeman/community-templates#548 which should be merged at the same time so next sync won't restore original template name.

[theforeman-bot]

Issues: #25894

[lzap]

Tests failed, can you rebase?

Also, isn't this template locked therefore seed would overwrite it correctly. What is the reason for adding explicit migration?

[ares]

If we sync new version from community-templates, seed will create a new one. It's not that smart it would rename the template to a new name. Therefore, migration needs to happen before seed. Seeding would only update the content. Name in this case is the template identifier... I fixed the migration that caused test failures.

[lzap]

Testing hold on.

[lzap]

I've executed migrate then seed and I ended up with two copies: Host statuses and Host statuses CSV.

[ares]

the last fix caused that, taxonomies didn't allow to find templates, it's now fixed by using unscoped

[lzap]

Hold my beer...

[lzap]

Allright!

[lzap@box foreman]$ echo "ReportTemplate.pluck(:name)" | bec
=> ["Applicable errata", "Host statuses CSV", "Registered hosts", "Subscriptions"]

[lzap@box foreman]$ be rake db:migrate
== 20190122115421 RenameHostStatusesReport: migrating =========================
== 20190122115421 RenameHostStatusesReport: migrated (0.0075s) ================

[lzap@box foreman]$ echo "ReportTemplate.pluck(:name)" | bec
=> ["Applicable errata", "Host statuses", "Registered hosts", "Subscriptions"]

[lzap@box foreman]$ be rake db:seed

[lzap@box foreman]$ echo "ReportTemplate.pluck(:name)" | bec
=> ["Applicable errata", "Host statuses", "Registered hosts", "Subscriptions"]

[lzap]

All set. Sorry for the delay.