Fixes #26154 - implement pxedir method for operatingsystem base #6616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #26154 |
ShimShtein
reviewed
Mar 25, 2019
| @@ -26,7 +26,7 @@ def interpolate_vars(pattern) | |||
|
|
|||
| def unique_id | |||
| @unique_id ||= begin | |||
| digest = Base64.urlsafe_encode64(Digest::SHA1.digest(medium_uri(entity.operatingsystem.pxedir).to_s), padding: false) | |||
| digest = Base64.urlsafe_encode64(Digest::SHA1.digest(medium_uri(entity.operatingsystem.try(:pxedir)).to_s), padding: false) | |||
There was a problem hiding this comment.
I wonder if it won't be more complete adding pxedir method to operatingsystem.rb, so the interface would be a bit more formal.
Default MediumProvider tries to use pxedir method on the operating system to generate a unique id. Not all OSes implement these method, causing provisioning to fail for windows.
tbrisker
changed the title
ShimShtein
approved these changes
Mar 25, 2019
|
Merged, thanks @tbrisker! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows OS doesn't implement the pxedir method, causing provisioining to
fail when trying to calculate the unique id for the medium provider.