Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #22174 - confirm password added for create host and hostgroup #6626

Conversation

amitkarsale
Copy link
Contributor

No description provided.

@theforeman-bot
Copy link
Member

Issues: #22174

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • length of the first commit message line for 0240213 exceeds 65 characters

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

Copy link
Member

@ohadlevy ohadlevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code wize looks good, I wonder if it makes sense to use the password strength meter (as in the users form)

@ares
Copy link
Member

ares commented Oct 2, 2019

Thanks @amitkarsale, we decided to close this PR as there were concers raised with the present behavior and due to the fact the BZ is already closed as "won't fix". Please reopen in case you plan to resume working on this.

@ares ares closed this Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants