Fixes #23699 - Remediation Support for Host Status #6690
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #23699 |
amitkarsale
force-pushed
the
23699_host_status_info
branch
from
038498d
to
7a61715
Compare
amitkarsale
force-pushed
the
23699_host_status_info
branch
from
7a61715
to
18e8a62
Compare
timogoebel
reviewed
Apr 17, 2019
| @@ -64,6 +64,21 @@ def token_expired? | |||
| def build_errors? | |||
| host && host.build_errors.present? | |||
| end | |||
|
|
|||
| def remediation_help_text | |||
| case to_status | |||
There was a problem hiding this comment.
This should use status. to_status can call expensive (external services). status just used the cached version in the database.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.