Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #26679 - Add report template API attributes #6711

Merged
merged 1 commit into from
Apr 26, 2019

Conversation

xprazak2
Copy link
Contributor

No description provided.

@theforeman-bot
Copy link
Member

Issues: #26679

Copy link
Member

@lzap lzap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM however jenkins needs retrigger. Ping me when green.

@xprazak2
Copy link
Contributor Author

[test foreman]
[test katello]

@lzap lzap merged commit b24b0f9 into theforeman:develop Apr 26, 2019
@lzap
Copy link
Member

lzap commented Apr 26, 2019

Thanks merged.

@ares
Copy link
Member

ares commented Apr 29, 2019

does this need to be cherrypicked to 1.22? setting 1.23 in redmine for now

@xprazak2
Copy link
Contributor Author

There was no target release for this AFAIK, but we cane cherry-pick if someone requests it.

@ares
Copy link
Member

ares commented May 24, 2019

Please open a cherry-pick to 1.22, it's extremely safe and our BZ asks for that. If you ping me there, I'm happy to merge, unless @tbrisker objects. Given this is the new functionality in 1.22, I think the API should be complete.

@xprazak2
Copy link
Contributor Author

xprazak2 commented Jun 4, 2019

I opened #6821

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants