-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #26935 - added stdout logging option back #6817
Conversation
Issues: #26935 |
I gave this a try and got the following error:
if you want to reproduce my env, just apply diff --git a/docker-compose.yml b/docker-compose.yml
index 821984ff2..91d21808d 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -20,7 +20,7 @@ services:
- db:/var/lib/mysql/data
app: &app_base
- image: quay.io/foreman/foreman:develop
+ image: quay.io/ohadlevy/foreman:lzap-logging-stdout-26935
command: bundle exec bin/rails server -b 0.0.0.0
build: |
a4b6422
to
457aed4
Compare
Try now. Works locally. |
thanks, while it doesnt break now, it doesnt actually anything after rails intiatlization code, e.g. I'm seeing
but nothing else afterwards (even if I have made multiple requests) - steps to reproduce are the same as in the above comment. thanks! |
What is in your |
it seems I was wrong, sorry, this does work as expected! |
Pfeeeeew that was close, you almost made me to start a container! 😌 |
With logging refactoring, we actually dropped ability to set STDOUT logging output for Rails. This ticket adds this possibility back.