Fixes #26957 - send request id instead session to proxy #6827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #26957 |
tbrisker
approved these changes
Jun 5, 2019
tbrisker
suggested changes
Jun 5, 2019
|
No changes needed actually for this to work properly, this core change (which I propose for 1.22) fixed the issue - session id is no longer sent as request id. Foreman proxy processes the parameter correctly (it was just bad data coming from core). Additionally, it now sends both, this will require change in Foreman Proxy (which I am going to work on later today), however this I don't propose into 1.22. That is improvement and it is not what we should be backporting. Rebased and fixed the tests. |
tbrisker
approved these changes
Jun 5, 2019
|
1.22.1- ceb8c2a |
|
Thanks a bunch! I will demo this tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We send the data to correlate logs but instead request we send session
id. This is confusing and this patch fixes that. Additionally, it also
now sends both so proxy can actually process and log both as both can be
useful when digging in logs.
Can I ask for this one into 1.22? We are targetting improving logging in
1.22 and this is a tiny bug that can make searching for logs confusing.
@tbrisker @ares