Fixes #27478 - extract onchange event handlers #6945
Conversation
|
Issues: #27478 |
app/assets/javascripts/host_edit.js
Outdated
| $(document).on('change', '#host_hostgroup_id', function(evt) { | ||
| hostgroup_changed(evt.target); | ||
| }); | ||
| $(document).on('change', '#host_compute_resource_id, #compute_profile', function(evt) { |
There was a problem hiding this comment.
are we certain there are no other matching elements anywhere in foreman or any of the plugins?
There was a problem hiding this comment.
should be as it is purpose of ID, but fair point... I can find some unique parent.
ezr-ondrej
force-pushed
the
obfuscate_select2_onchange
branch
from
2726f4b
to
4ff77fd
Compare
There was a problem hiding this comment.
Thanks @ezr-ondrej
Looks like there are relevant failing tests:
https://ci.theforeman.org/job/test_develop_pr_core/1605/database=postgresql-integrations,ruby=2.5,slave=fast/testReport/junit/(root)/HostgroupJSTest/test_0004_parameters_change_after_parent_update/
| $(document) | ||
| .on('change', '.hostgroup-select', function(evt) { | ||
| hostgroup_changed(evt.target); | ||
| }).on('change', '.host-form-compute-resource-handle', function(evt) { |
There was a problem hiding this comment.
What's the difference between select suffix and handle suffix?
Aren't they all selects?
There was a problem hiding this comment.
The handle class is used more than once 🤔
I am terrible with naming... any ideas?
There was a problem hiding this comment.
What about something like this? (not sure if it's the right syntax)
| }).on('change', '.host-form-compute-resource-handle', function(evt) { | |
| }).on('change', '.host-form-compute-resource-select, .host-form-compute-profile-select', function(evt) { |
| @@ -23,7 +23,7 @@ | |||
|
|
|||
| <div class="tab-pane active" id="primary"> | |||
| <%= select_f(f, :parent_id, parent_hostgroups, :id, :to_label, {:include_blank => true}, {:label => _('Parent'), | |||
| :onchange => 'hostgroup_changed(this);', :'data-url'=> process_hostgroup_hostgroups_path, | |||
There was a problem hiding this comment.
Looks like the data-url is needed here:
foreman/app/assets/javascripts/host_edit.js
Line 332 in 10c8905
It might be the reason https://ci.theforeman.org/job/test_develop_pr_core/1605/database=postgresql-integrations,ruby=2.5,slave=fast/testReport/junit/(root)/HostgroupJSTest/test_0004_parameters_change_after_parent_update/ is failing
There was a problem hiding this comment.
yeah, I meant to rewrite it, but it slipped my fingers 🙄 🤦♂️
(:arrow_down:)
ezr-ondrej
force-pushed
the
obfuscate_select2_onchange
branch
from
4ff77fd
to
b516af1
Compare
|
@amirfefer can you take a look, so we can merge the webcomponents? |
theforeman-bot
added
Waiting on contributor
Legacy JS
This seems to be intentional, not an regression and it got called only when compute resource is 'Bare Metal': foreman/app/assets/javascripts/host_edit.js Line 354 in b90f097 in such case the event is just ensuring the VM related fields are hidden. |
ezr-ondrej
force-pushed
the
obfuscate_select2_onchange
branch
from
b516af1
to
322193f
Compare
mmoll
force-pushed
the
obfuscate_select2_onchange
branch
from
322193f
to
de83d76
Compare
|
[test foreman] |
|
merged, díky @ezr-ondrej! |
No description provided.