Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.20 JS memory settings #6952

Merged
merged 2 commits into from Aug 6, 2019
Merged

1.20 JS memory settings #6952

merged 2 commits into from Aug 6, 2019

Conversation

mmoll
Copy link
Contributor

@mmoll mmoll commented Aug 6, 2019

No description provided.

iNecas and others added 2 commits August 6, 2019 11:26
The default value started causing:

    Allocation failed - JavaScript heap out of memory

Increasing max_old_space_size should fix the issue. Unfortunately,
webpack-rails doesn't allow to set params for node. Therefore we to
override the rake task by our own. Take directly from (with extension of
the node parameter)

    https://github.com/mipearson/webpack-rails/blob/v0.9.11/
    lib/tasks/webpack.rake

(cherry picked from commit 56640d9)
@theforeman-bot
Copy link
Member

Issues: #26826

@theforeman-bot theforeman-bot added Needs testing Not yet reviewed Stable branch PRs that are opened against a stable branch. Usually a cherry pick labels Aug 6, 2019
@mmoll mmoll merged commit 8713b65 into theforeman:1.20-stable Aug 6, 2019
@mmoll mmoll deleted the 1.20_js_mem branch August 6, 2019 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs testing Not yet reviewed Stable branch PRs that are opened against a stable branch. Usually a cherry pick
Projects
None yet
4 participants