Fixes #27897 - Parameter type is not required

[ofedoren]

As I mentioned in the issue, it causes backward incompatibility (at least in the hammer, but there could be a problem in the custom scripts that use API).

[theforeman-bot]

Issues: #27897

[ekohl]

cad1fc3 is the commit in question that added it via #6965. I agree it shouldn't be required. Prior to the commit it was a string and for API backwards compatibility this should remain.

Could you add a test that verifies the type is a string when not passed in to prevent future regressions?

[ofedoren]

@ekohl, I added the test, but when was looking at it in debug I saw that without this change

foreman/app/models/parameter.rb

Lines 80 to 82 in aabda05

	def set_default_key_type
	self.key_type ||= Parameter::KEY_TYPES.first
	end

it defaults to nil not "string".

[ekohl]

LGTM but I'd prefer someone with more rails knowledge to give it a look.

[ekohl]

This this test also assert that it was created with the string type?

[ofedoren]

This test just asserts that creating doesn't fail if no parameter_type was provided.

[ofedoren]

The following test does check if there is no parameter type was provided then it defaults to "string"

foreman/test/controllers/api/v2/hostgroups_controller_test.rb

Line 252 in f4d91de

assert_equal 'string', show_response['parameters'].first['parameter_type']

[ofedoren]

[test foreman]

[tbrisker]

Thanks @ofedoren !