[WIP] Fixes #27913 - Add pagination to table component #7061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #27913 |
MariaAga
force-pushed
the
feat/add-pagination-to-table
branch
from
d10b26c
to
1fae7aa
Compare
1 similar comment
xprazak2
reviewed
Sep 25, 2019
| const { REQUEST, FAILURE, SUCCESS } = createTableActionTypes(tableID); | ||
|
|
||
| switch (action.type) { | ||
| const { REQUEST, FAILURE, SUCCESS, SET_PAGINATION } = createTableActionTypes( |
There was a problem hiding this comment.
Looking at changes in Table, are we ok with having SET_PAGINATION for tables that are not paginated?
There was a problem hiding this comment.
It will just be not used, I don't see the harm in that
MariaAga
force-pushed
the
feat/add-pagination-to-table
branch
from
1fae7aa
to
5d44379
Compare
MariaAga
changed the title
theforeman-bot
added
Waiting on contributor
and removed
Needs testing
Not yet reviewed
labels
|
@MariaAga, this pull request is currently not mergeable. Please rebase against the develop branch and push again. If you have a remote called 'upstream' that points to this repository, you can do this by running: This message was auto-generated by Foreman's prprocessor |
|
@MariaAga is this ready to test? Or do you need to rebase again? |
|
This is not ready at all yet |
|
This has been without a change for more than 3 months, therefore I will close. Feel free to reopen if you find time to work on this @MariaAga! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a pagination to the table including the needed actions and reducers.
usage example PR - #7064