Fixes #25613 - template renderer tests use os, family, loader

[lzap]

This greatly enhances coverage of our tests.

[theforeman-bot]

Issues: #25613

[lzap]

I think PXE loader is useless in this context, let me remove it.

[lzap]

Rebased, added more OSes. Some templates are rendered with irrelevant context, but git will work fine with few more files and we want to cover as much as possible.

[lzap]

Test is not right, need to work on this more.

[timogoebel]

Can we get this from the template metadata?

[lzap]

Well only operating system name and version. Not family and possibly other things. I'd rather be explicit. I am currently working on adding host params here.

[timogoebel]

Note, that this is something we'd need to keep in sync when importing community templates. I doubt this will actually work.

[lzap]

Well, I want specifically to be testing RHEL 6, 7, 8 and similarly Debian/Ubuntu. Let me think about it tomorrow.

[timogoebel]

Note, that instead of changing the test implementation we'd better move the code to use

foreman/app/services/foreman/render_templates_from_folder.rb

Line 2 in 2721014

class RenderTemplatesFromFolder

, which has a better design.

[lzap]

Timo, do you think merging TemplateSnapshotService and RenderTemplatesFromFolder into one class? I don't understand why this was created in the first place, but I was one merging it so no excuses.

[timogoebel]

Timo, do you think merging TemplateSnapshotService and RenderTemplatesFromFolder into one class?

Yep, that would be great. RenderTemplatesFromFolder has the better design and should be used as a default.

[theforeman-bot]

Thank you for your contribution, @lzap! This PR has been inactive for 3 months, closing for now.
Feel free to reopen when you return to it. This is an automated process.