Fixes #24838 - Use integer representation for boolean on sqlite

[tbrisker]

We don't really need to migrate boolean fields as sqlite isn't supported
production database and is only used for running build tasks.

[theforeman-bot]

Issues: #24838

[tbrisker]

Migration is not trivial, most fields can be converted using the following task but there are many that aren't covered in it (either in core or in plugins):

      if ActiveRecord::Base.connection.adapter_name.downcase.starts_with?('sqlite')
        ActiveRecord::Base.connection.tables.map do |t|
          t.classify.constantize rescue nil
        end.compact.each do |t|
          next unless t.respond_to? :columns
          t.columns.each do |col|
            next unless col.type == :boolean
            next if col.name == 'default'
            t.where("#{col.name} = 't'").update_all(col.name.to_sym => 1)
            t.where("#{col.name} = 'f'").update_all(col.name.to_sym => 0)
          end
        end
      end

[mmoll]

We might also declare SQLite as dev only and unsafe for upgrades or similar ;)

[adamruzicka]

Haven't tested the migration, but the actual patch makes sense and works nicely for me.

[mmoll]

upgrade test fails 💔

[tbrisker]

that's wierd, it failed to create an admin user on 1.14... [test upgrade]

[mmoll]

@tbrisker Perhaps it's saved in the "old" format on the old Rails version and with that setting the new Rails isn't detecting it correctly?

[tbrisker]

@mmoll it is, the seed is failing to find it due to the way it checks for existing admin user. I'll work around that in a second.

[tbrisker]

only_admin doesn't find the exising admin user when upgrading due to the changed format. I've made this seed more sensitive so it first checks if a user with the admin login exists, which will also be good so it doesn't fail when trying to seed an existing user name.

[mmoll]

Fine for me 👍. @tbrisker Could you add an 1.24 upgrade warning with the migration script? I hope, not many people are using sqlite, especially in production...

[tbrisker]

Opened theforeman/theforeman.org#1501 but looks like we actually default to SQLite on non-installer installations, I wonder how many users we have that use sqlite in production due to this.

[tbrisker]

opened an RFC on discourse to make sure we can really drop sqlite in production: https://community.theforeman.org/t/dropping-support-for-sqlite-as-production-database/16158

[mmoll]

merged, thanks @tbrisker!