Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #28542 - Remove smart variables from puppet class form #7291

Merged
merged 1 commit into from
Dec 26, 2019

Conversation

tbrisker
Copy link
Member

No description provided.

@theforeman-bot
Copy link
Member

Issues: #28542

@theforeman-bot theforeman-bot added Needs testing Not yet reviewed Legacy JS PRs making changes in the legacy Javascript stack labels Dec 25, 2019
@mmoll
Copy link
Contributor

mmoll commented Dec 25, 2019

integration tests fail 💔

@tbrisker
Copy link
Member Author

[test foreman] that's odd, my changes shouldn't affect any pages other than the puppet ones and they seem to be passing locally.

@mmoll
Copy link
Contributor

mmoll commented Dec 26, 2019

💚 now

@mmoll mmoll merged commit 822ff7c into theforeman:develop Dec 26, 2019
@mmoll
Copy link
Contributor

mmoll commented Dec 26, 2019

merged, thanks @tbrisker!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Legacy JS PRs making changes in the legacy Javascript stack Needs testing
Projects
None yet
3 participants