Fixes #28585 - Drop host status api without type #7302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `hosts/<id>/status` api endpoint has been deprecated in favor of more specific status types.
|
Issues: #28585 |
|
theforeman/theforeman.org#1518 is the docs |
|
[test katello] |
timogoebel
reviewed
Dec 29, 2019
| param :type, [ HostStatus::Global ] + HostStatus.status_registry.to_a.map { |s| s.humanized_name }, :required => true, :desc => N_( | ||
| <<~EOS | ||
| status type, can be one of | ||
| * global |
There was a problem hiding this comment.
Can we retrieve this from the status registry?
There was a problem hiding this comment.
IIRC we normally generate the apidoc during packaging, meaning that it won't catch any others anyway except for the rare few who regenerate the doc
mmoll
approved these changes
Dec 31, 2019
|
merged, thanks @tbrisker! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
hosts/<id>/statusapi endpoint has been deprecated in favor ofmore specific status types.