Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #28567 - Remove smart variables strong param filters #7309

Merged
merged 1 commit into from
Dec 31, 2019
Merged

Fixes #28567 - Remove smart variables strong param filters #7309

merged 1 commit into from
Dec 31, 2019

Conversation

orrabin
Copy link
Member

@orrabin orrabin commented Dec 30, 2019

No description provided.

@theforeman-bot
Copy link
Member

Issues: #28567

@mmoll
Copy link
Contributor

mmoll commented Dec 30, 2019

[test foreman]

@mmoll
Copy link
Contributor

mmoll commented Dec 30, 2019

@orrabin Katello test failure related.

@mmoll
Copy link
Contributor

mmoll commented Dec 30, 2019

[test foreman]

@mmoll
Copy link
Contributor

mmoll commented Dec 30, 2019

Foreman test failures also related, IMHO

@orrabin
Copy link
Member Author

orrabin commented Dec 31, 2019

Foreman test failures are related, I'm moving it to WoC and I'll fix them.

tbrisker
tbrisker approved these changes Dec 31, 2019
View reviewed changes
Copy link
Member

@tbrisker tbrisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @orrabin !

@tbrisker tbrisker merged commit 3fd72c6 into theforeman:develop Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbrisker tbrisker tbrisker approved these changes

Assignees
No one assigned
Labels
Needs testing
Projects
None yet
Milestone
No milestone
4 participants
@orrabin @theforeman-bot @mmoll @tbrisker