Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #1618 #7313

Closed
wants to merge 3 commits into from
Closed

fixes #1618 #7313

wants to merge 3 commits into from

Conversation

connormcdermid
Copy link

No description provided.

@theforeman-bot
Copy link
Member

Can one of the admins verify this patch?

2 similar comments
@theforeman-bot
Copy link
Member

Can one of the admins verify this patch?

@theforeman-bot
Copy link
Member

Can one of the admins verify this patch?

houndci-bot
houndci-bot reviewed Jan 1, 2020
View reviewed changes
app/helpers/reports_helper.rb
link_to config_report_path(record) do
date_time_relative(record.reported_at)
end
word = record.reported_at.getlocal > Time.now ? " ahead" : " ago"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/TernaryParentheses: Use parentheses for ternary expressions with complex conditions.

@theforeman-bot
Copy link
Member

Issues: #1618

@tbrisker
Copy link
Member

tbrisker commented Jan 1, 2020

Hello @CAM-o-man and thank you for the contribution!
Unfortunately, looks like you stumbled across a very old bug report that is no longer valid - report dates are now displayed using a React relative date component which correctly displays future dates as e.g. in 1 day.
We appreciate your effort very much, but I'm going to close this PR and the bug report in our tacker as it has been resolved already in current versions. I hope to see more contributions from you in the future!
You are very welcome to join us on #theforeman-dev channel on Freenode IRC, or the development board on community.theforeman.org for help finding other issues to work on.

@tbrisker tbrisker closed this Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

Assignees
No one assigned
Labels
Needs testing Not yet reviewed Waiting on contributor
Projects
None yet
Milestone
No milestone
4 participants
@connormcdermid @theforeman-bot @tbrisker @houndci-bot