Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #28863 - upgrade tfm-builder to v4.0.7 #7393

Merged
merged 1 commit into from Jan 27, 2020

Conversation

sharvit
Copy link
Contributor

@sharvit sharvit commented Jan 27, 2020

In order to prevent webpack to do tree-shaking,
tfm-builder v4.0.7 set modules to commonjs.

In order to prevent webpack to do tree-shaking,
tfm-builder v4.0.7 set modules to commonjs.
@theforeman-bot
Copy link
Member

Issues: #28863

@tbrisker
Copy link
Member

packaging is at theforeman/foreman-packaging#4653

@tbrisker
Copy link
Member

correction, packaging for builder is at theforeman/foreman-packaging#4654 and vendor at theforeman/foreman-packaging#4656

Copy link
Member

@tbrisker tbrisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sharvit !

@tbrisker tbrisker merged commit 2508258 into theforeman:develop Jan 27, 2020
@sharvit sharvit deleted the fix/update-builder branch January 28, 2020 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants