Fixes #29470 - Rails 6 compatible method calls #7561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Apr 5, 2020
tbrisker
reviewed
Apr 5, 2020
ezr-ondrej
force-pushed
the
rails_6
branch
2 times, most recently
from
2dcc674
to
930486f
Compare
tbrisker
reviewed
Apr 6, 2020
app/registries/foreman/plugin.rb
Outdated
Comment on lines
348
to
350
| ActiveRecord::Migrator.migrations_paths, ActiveRecord::SchemaMigration).migrations | ||
| pending_migrations = ActiveRecord::Migrator.new(:up, migration_paths, ActiveRecord::SchemaMigration). | ||
| pending_migrations |
There was a problem hiding this comment.
Do we really need all this code? ActiveRecord::Base.connection.migration_context.needs_migration? will give the same return value afaict, we would lose the debug logging but i highly doubt it's actually useful at all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves to rails 6 syntax and adds a patch file to keep compatibility to Rails 5.2