Fixes #29433 - seeding with scope #7597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #29433 |
|
[test foreman] moody integrational tests |
ezr-ondrej
force-pushed
the
seed_change_eval
branch
from
4a305aa
to
09c9b69
Compare
kgaikwad
approved these changes
Apr 23, 2020
|
@tbrisker, |
|
Works perfectly! Tested the below scenarios:
|
tbrisker
approved these changes
Apr 27, 2020
There was a problem hiding this comment.
seeing the thorough testing i'll approve, but tbh I think we should stop relying on audits to decide what should be seeded. definitely out of scope for this pr but i'd love to get rid of all these audit checks in the seed helper, i think they cause more trouble than they solve.
Thanks @ezr-ondrej and @kgaikwad !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the seeding filter is broken if there is unexpected change to the checked resource.
Update audit contains only changed attributes