Fixes #29734 - Fix bar chart on config report page #7645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #29734 |
xprazak2
force-pushed
the
config-rep
branch
2 times, most recently
from
dd4964b
to
236b8a9
Compare
|
Much better, but looks like the chart is still overflowing a bit: |
|
I first thought it was a duplicate of https://projects.theforeman.org/issues/26090, but looks like it's just a similar issue on a different page. |
|
Thanks, donut chart should be now contained within the card as well. |
tbrisker
approved these changes
May 13, 2020
ekohl
reviewed
Jun 1, 2020
| <ChartBox | ||
| {...chartBoxProps} | ||
| type="bar" | ||
| chart={{ data: statusChartData, id: 'report-status' }} | ||
| title={__('Report Status')} | ||
| /> | ||
| </Col> | ||
| <Col md={4}> | ||
| <Col md={2}> |
There was a problem hiding this comment.
This makes it very hard to read on a smaller screen:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.