Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #30041 - Don't allow impersonate disabled user #7734

Merged
merged 1 commit into from Jun 10, 2020
Merged

Fixes #30041 - Don't allow impersonate disabled user #7734

merged 1 commit into from Jun 10, 2020

Conversation

domitea
Copy link
Contributor

@domitea domitea commented Jun 9, 2020

No description provided.

@theforeman-bot
Copy link
Member

Issues: #30041

ezr-ondrej
ezr-ondrej reviewed Jun 9, 2020
View reviewed changes
Copy link
Member

@ezr-ondrej ezr-ondrej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add the check here as well?

foreman/app/controllers/users_controller.rb

Line 78 in a9d260c

user = User.find_by_id(params[:id])

I'd suggest moving the user selection on top of the function as User.enabled.find_by_id and add an if branch for user.nil?

ezr-ondrej
ezr-ondrej approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@ezr-ondrej ezr-ondrej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @domitea !

@ezr-ondrej ezr-ondrej merged commit 5960679 into theforeman:develop Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezr-ondrej ezr-ondrej ezr-ondrej approved these changes

Assignees

@ezr-ondrej ezr-ondrej

Labels
Needs testing
Projects
None yet
Milestone
No milestone
3 participants
@domitea @theforeman-bot @ezr-ondrej