Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #30611 - webcomponent mount FactChart #7891

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Fixes #30611 - webcomponent mount FactChart #7891

merged 1 commit into from
Aug 12, 2020

Conversation

ezr-ondrej
Copy link
Member

Transfer to a new mounter introduced in 6f0d802

@theforeman-bot
Copy link
Member

Issues: #30611

@coveralls
Copy link

Coverage Status

Coverage remained the same at 73.789% when pulling ca7aefa on ezr-ondrej:mount_react/30611 into 6bd234d on theforeman:develop.

@xprazak2
Copy link
Contributor

xprazak2 commented Aug 11, 2020 •
edited
Loading

PropTypes might need an adjustment for tests to pass.

@ezr-ondrej
Fixes #30611 - webcomponent mount FactChart
3baa7d1 
Transfer to a new mounter introduced in 6f0d802
@ezr-ondrej
Copy link
Member Author

PropTypes might need an adjustment for tests to pass.

Thanks ^_^ done 👍

sharvit
sharvit approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@sharvit sharvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected 👍

@tbrisker tbrisker merged commit 8709154 into theforeman:develop Aug 12, 2020
@ezr-ondrej ezr-ondrej deleted the mount_react/30611 branch August 12, 2020 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharvit sharvit sharvit approved these changes

Assignees
No one assigned
Labels
Needs testing UI
Projects
None yet
Milestone
No milestone
6 participants
@ezr-ondrej @theforeman-bot @coveralls @xprazak2 @sharvit @tbrisker