Fixes #30929 - Deprecate ovirt v3 API #8046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 6, 2020
|
Issues: #30929 |
tbrisker
reviewed
Oct 6, 2020
Comment on lines
17
to
18
| <%= alert :header => '', :class => 'alert-warning', :close => false, | ||
| :text => _("API v3 is deprecated and will be removed completely in foreman 2.4") %> |
There was a problem hiding this comment.
Should this be next to the api version checkbox? perhaps the help text for it should also be changed?
tbrisker
suggested changes
Oct 12, 2020
houndci-bot
reviewed
Oct 12, 2020
tbrisker
reviewed
Oct 12, 2020
shiramax
force-pushed
the
30929
branch
2 times, most recently
from
41e9739
to
b71c9b1
Compare
tbrisker
reviewed
Oct 13, 2020
config/initializers/deprecations.rb
Outdated
Comment on lines
18
to
24
| :links => [ | ||
| { | ||
| :href => 'https://community.theforeman.org/t/suggestion-to-drop-ovirt-api-v3-from-foreman/19915', | ||
| :title => _('Further Information'), | ||
| :external => true, | ||
| }, | ||
| ], |
There was a problem hiding this comment.
No crucial, feel free to say no - While rubocop doesn't yell about it since it's different hashes, would it make sense to make the internal hashes also in the new style instead of hash rockets for consistency?
tbrisker
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.