Fixes #31364 - Properly import facts when unattended == false #8161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fact importer calls host.without_orchestration which is defined in orchestration concern, however the concern is only included when unattended == true. Users who have the setting set to false will not be able to import facts as the fact importer will fail to find this method.
|
Issues: #31364 |
|
see GH-8160 for why we can't really test this properly. This change should be CPed down to 2.2-stable and 2.3-stable. |
|
[test katello] |
ezr-ondrej
approved these changes
Nov 29, 2020
There was a problem hiding this comment.
Thanks for addressing this @tbrisker, silly me didn't realize Orchestration is not included, I guess we could use respond_to?, but I like this fix more as this prevents others making the same mistake. Let's get this in and discuss what we can do about this not happening in the future in the other PR 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact importer calls host.without_orchestration which is defined in
orchestration concern, however the concern is only included when
unattended == true. Users who have the setting set to false will not be
able to import facts as the fact importer will fail to find this method.