Correct coloring of zero metrics in report overviews #8406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
ok to test |
pr theforeman#8118 changed to the use of strings for these metrics. This made the comparison with the integer of 0 fail, resulting in all metrics being colord even if they were 0 That same pr also failed to apply this change to the reports widget, which is updated here to have the same behaviour as the config_reports/_list view
LadyNamedLaura
force-pushed
the
config-report-metric-coloring
branch
from
dc60d6d
to
bc330c4
Compare
|
2.4 - 823b3f6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pr #8118 changed to the use of strings for these metrics.
This made the comparison with the integer of 0 fail, resulting in all
metrics being colord even if they were 0
That same pr also failed to apply this change to the reports widget,
which is updated here to have the same behaviour as the
config_reports/_list view
It would be nice to still get this into 2.4