Fixes #33342 - plugins can avoid lone taxonomies

[lzap]

Some model classes treat taxonomies differently and therefore API base controller filter is not applicable. This patch introduces a mechanism (an empty mixin) to opt-in.

[theforeman-bot]

Issues: #33342

[xprazak2]

Nice, though I am not sure if it should be in core or handled in a plugin. We had a fix in openscap which was recently removed - it was no longer needed because ArfReport < Report so if we remove the inheritance, maybe we could bring it back.

[xprazak2]

@lzap, rubocop needs a fix if you plan to move forward here

[lzap]

I plan to remove STI from SCAP report table however since I have no idea what lone taxonomies are, I was unsure what to do. So I simply went ahead and created this empty module.

Rebased. I'd appreciate guidance here, if you think there is a better solution let's do it!

[xprazak2]

@tbrisker, is this something worth having in core?

[tbrisker]

Some background: This callback is used when there is only one location or organization and a resource is created via the API. In that case, even if the user doesn't specify the taxonomy, it gets assigned to the resource. This was needed when we removed the option to disable taxonomies, so that the same behaviour is preserved when people only use the default taxonomies and automation doesn't need changes.

What might be a better solution is to not assign them when they are a through relation, maybe something like:

  if resource_class.reflections.has_key? tax_name.pluralize
    next if resource_class.reflections[tax_name.pluralize].options.has_key? :through
...
  elsif resource_class.reflections.has_key? tax_name
    next if resource_class.reflections[tax_name].options.has_key? :through

I'm not 100% certain about that, but it does make some sense to me when the taxonomy isn't directly assigned that the api shouldn't assign it automatically as well.

[lzap]

I am not sure what am I doing here, I've been told to do this kind of patch. Closing.