Fixes #33025 - allow filtering hosts by user id #8767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users would like to set filters so users can only see reports of hosts they own. For that we can define an association on a Report based on the Host ownership. Then we can add a scoped search definition that could be used in Filter definition. The resulting scoped search term that can be used on any Report subclass is ``` host_owner_id = current_user ``` Instead of `current_user`, a specific user ID can be used too. This will not take user group ownership into the consideration due to the complexity, especially when tree structure of user groups is considered.
|
Issues: #33025 |
|
rubocop complains about the line I haven't touched, I added a second commit that fixes the spacing, but of course is unrelated, it should be kept separate on merge if we decide to cherry-pick the first definition |
ezr-ondrej
reviewed
Sep 8, 2021
app/models/report.rb
Outdated
| :only_explicit => true, | ||
| :validator => ->(value) { ScopedSearch::Validators::INTEGER.call(value) }, | ||
| :value_translation => ->(value) { value == 'current_user' ? User.current.id : value }, | ||
| :special_values => %w[current_user] | ||
| scoped_search :relation => :organization, :on => :name, :complete_value => true, :rename => :organization |
There was a problem hiding this comment.
You've missed one and now rubocop doesn't like it when it's not aligned with others
Suggested change
| scoped_search :relation => :organization, :on => :name, :complete_value => true, :rename => :organization | |
| scoped_search :relation => :organization, :on => :name, :complete_value => true, :rename => :organization |
|
updated |
|
no packaging ack needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users would like to set filters so users can only see reports of hosts
they own.
For that we can define an association on a Report based on the Host
ownership. Then we can add a scoped search definition that could be used
in Filter definition. The resulting scoped search term that can be used
on any Report subclass is
Instead of
current_user, a specific user ID can be used too.This will not take user group ownership into the consideration due to
the complexity, especially when tree structure of user groups is
considered.