Fix PR #871 #879
Closed
Fix PR #871 #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -48,8 +49,10 @@ def self.[](name) | |||
| def self.[]=(name, value) | |||
| name = name.to_s | |||
| record = find_or_create_by_name name | |||
| record.value = value | |||
| record.save! | |||
| Setting.bypass_readonly(record) do |rec| | |||
There was a problem hiding this comment.
Is this needed for anything? This is the one place we shouldn't really override readonly...
There was a problem hiding this comment.
It's not needed, I just wanted to make sure values are updated. First I thought about readonly settings only as a UI functionality but you're correct, with this there would be no sense in having bypass method. I reverted this.
|
I squashed to one commit, feel free to merge this instead of #871 or update your original PR. |
This was referenced Sep 14, 2013
|
👍 from me for @ares' changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one fixes #871, leaving as separate commits to review, I can squash when ready. Also @domcleals's commit was rebased to develop, that's why it has another hash. Test should be green now. Please review also other fixes.