Fixes #33560 - Pin @types/jest #8793
Conversation
|
Issues: #33560 |
|
Issues: #33560 |
| @@ -34,6 +34,7 @@ | |||
| "@theforeman/stories": "^8.7.0", | |||
| "@theforeman/test": "^8.7.0", | |||
| "@theforeman/vendor-dev": "^8.7.0", | |||
| "@types/jest": "<27.0.0", | |||
There was a problem hiding this comment.
Shouldn't this be @jest/types? ;)
There was a problem hiding this comment.
I think I got this one right:
There was a problem hiding this comment.
huh, okay, the pr title was jest/types, so I thought that's correct ;)
|
Looking more closely, can you please add |
xprazak2
force-pushed
the
pin-jest-types
branch
from
e8921aa
to
4ad5c95
Compare
theforeman-bot
added
Waiting on contributor
and removed
Needs testing
Not yet reviewed
labels
|
@xprazak2, this pull request is currently not mergeable. Please rebase against the develop branch and push again. If you have a remote called 'upstream' that points to this repository, you can do this by running: This message was auto-generated by Foreman's prprocessor |
xprazak2
force-pushed
the
pin-jest-types
branch
from
4ad5c95
to
39c7de7
Compare
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
All green now. |
|
Can we get this pinned, pretty please? |
|
We need @evgeni to ack... |
package-exclude.json
Outdated
| @@ -33,6 +33,7 @@ | |||
| ], | |||
| "EXCLUDE_NPM_PREFIXES": [ | |||
| "@babel/eslint-", | |||
| "@jest/", | |||
There was a problem hiding this comment.
looks like the prefix below is @types, not @jest? :)
no idea if you want to exclude all @types here in prefixes, or just @types/jest in the packages list above -- I have no idea what @types is for a namespace
There was a problem hiding this comment.
we definitelly don't want to exclude all @types, there are shared types accross packages, so eg patternfly can have types under that namespace.
xprazak2
changed the title
xprazak2
force-pushed
the
pin-jest-types
branch
from
39c7de7
to
2f3de52
Compare
|
Thanks, I added |
RTL jest-dom publishes its types in
@types/testing-lib__jest-dom, which has open-ended dependency on@types/jest. That causes@types/jest27.y.z to be pulled in, which in turns bringsjest-diffandjest-get-typefrom the 27 release while other jest packages remain at version 26, which derails the tests.