Refs #33551 - fix the searching in audits by user #8864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first PR allowed to search in search_users relation, however that searches on the actual audited objects. So when used in filters, it would grant access to see all audits of $my account by anyone. While such search may still be useful, the original intention was to allow searching by the author of the audit. Given the user is already a search keyword, we call this authored_by_user. The correct syntax then is authored_by_user = admin authored_by_user = current_user authored_by_user.id = 2 authored_by_user.id = current_user
|
Issues: #33551 |
|
@ezr-ondrej this should probably go in 3.0, the original PR does not cause any harm but some confusion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first PR allowed to search in search_users relation, however that
searches on the actual audited objects. So when used in filters, it
would grant access to see all audits of $my account by anyone. While
such search may still be useful, the original intention was to allow
searching by the author of the audit.
Given the user is already a search keyword, we call this
authored_by_user. The correct syntax then is
authored_by_user = admin
authored_by_user = current_user
authored_by_user.id = 2
authored_by_user.id = current_user