Fixes #32064 - drop Puppet related settings #8881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #32064 |
|
@ezr-ondrej looks like test failures are related |
ezr-ondrej
force-pushed
the
drop_puppet_settings
branch
2 times, most recently
from
135075e
to
3afdf4e
Compare
|
one more related failure (and one unrelated) |
Keeps Puppet CA settings as Puppet CA is still in. Extracted in: theforeman/foreman_puppet#122
ezr-ondrej
force-pushed
the
drop_puppet_settings
branch
from
3afdf4e
to
489e470
Compare
tbrisker
approved these changes
Nov 1, 2021
There was a problem hiding this comment.
Failing test was fixed in GH-8889, upgrade failures will hopefully be fixed by GH-8888. Thanks @ezr-ondrej !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted in: theforeman/foreman_puppet#122