Fixes #34063 - Drop deprecated Host#import_facts method #8961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #34063 |
|
Plugin PRs: There are also a couple of uses in puppetdb and default_hostgroup plugins but they seem to be unmaintained. |
ezr-ondrej
previously approved these changes
Dec 3, 2021
There was a problem hiding this comment.
once Katello PR gets in this is ready.
Nice cleanup @tbrisker :)
|
[test katello] |
1 similar comment
|
[test katello] |
|
[test katello] what the heck |
ezr-ondrej
approved these changes
Dec 8, 2021
|
It's already done, not perfectly, but done 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Katello test will fail, as will some other plugins that still use this method. Will open PRs to clean up there as well.