Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #3077 - locale was set to last language by default #900

Closed
wants to merge 1 commit into from

Conversation

lzap
Copy link
Member

@lzap lzap commented Sep 20, 2013

So during initialization we are switching current locale into all available
languages to fetch translation of all human readable language names. There
was a bug when default language was set before this loop, so for users in
1.3 RC1 locale was always set to last available language (usually Chinese).

@domcleal
Copy link
Contributor

I think we should additionally make register_human_localenames side-effect free? Can we save the original locale and add an 'ensure' block to restore it at the end?

@domcleal
Copy link
Contributor

Thanks @lzap! Merged as 219879c for Foreman 1.3.

@domcleal domcleal closed this Sep 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants