Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #3134 vSphere UI host create/edit requires some fixes #901

Closed
wants to merge 2 commits into from
Closed

fix #3134 vSphere UI host create/edit requires some fixes #901

wants to merge 2 commits into from

Conversation

mmatuska
Copy link
Contributor

fix issue #3134

Host create/edit mode:

  • Editing of existing VMs is not yet supported, networks and storage should by grayed out by now
  • The new network interface type selection does not detect already configured values
  • The thick/thin provisioning checkbox should not always be on
  • If cloning a VM, the Virtual Machine options should be identical as source VM and editable (not grayed out)

end
interface["type"] = ("RbVmomi::VIM::" + interface["type"]).constantize
# Convert network id into name
net = networks.find { |n| n.id == interface["network"] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing, but perhaps cache networks outside of the loop? I think we've learned that vSphere queries are expensive :)

Cache networks to reduce number of calls against vSphere
@domcleal
Copy link
Contributor

domcleal commented Oct 8, 2013

Thanks for the contribution @mmatuska. Merged as 29769a4 for Foreman 1.4.0. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants