fixes #3147 - added httpd logs into foreman-debug #907
Conversation
| @@ -238,6 +238,7 @@ add_files /etc/puppet/ssl/ca/inventory.txt /var/lib/puppet/ssl/ca/inventory.txt | |||
| add_cmd "find /etc/puppet/modules -exec ls -ld {} +" "puppet_manifests_tree" | |||
| add_files /etc/{httpd,apache2}/conf/* | |||
| add_files /etc/{httpd,apache2}/conf.d/* | |||
| add_files /var/log/httpd/*.log | |||
There was a problem hiding this comment.
I'm concerned that this will collect too much sensitive data. If users have stuff other than their foreman instance (or even just foreman), they'll be giving up a lot of data about who and what is using Foreman and I'm not sure I'd be comfortable with that as a user.
There was a problem hiding this comment.
+1 - I don't think is very useful, as it'll only contain passenger errors. We can always ask for that is we suspect a passenger problem.
There was a problem hiding this comment.
Why not split the logs in our vhost?
On Sep 25, 2013 1:36 PM, "Greg Sutcliffe" notifications@github.com wrote:
In script/foreman-debug:
@@ -238,6 +238,7 @@ add_files /etc/puppet/ssl/ca/inventory.txt /var/lib/puppet/ssl/ca/inventory.txt
add_cmd "find /etc/puppet/modules -exec ls -ld {} +" "puppet_manifests_tree"
add_files /etc/{httpd,apache2}/conf/*
add_files /etc/{httpd,apache2}/conf.d/*
+add_files /var/log/httpd/*.log+1 - I don't think is very useful, as it'll only contain passenger errors.
We can always ask for that is we suspect a passenger problem.—
Reply to this email directly or view it on GitHubhttps://github.com//pull/907/files#r6568916
.
There was a problem hiding this comment.
@GregSutcliffe er, that's precisely what we're trying to fix so we can quickly fix passenger errors. The point of this tool is to collect data useful for diagnosing common error conditions, and Passenger is a part of that.
I don't know if changing the logs will help with some Passenger initialisation errors (particularly on Passenger 3), it'd need to be tested. I'd restrict it to the error logs though, no need for access logs, which could contain more sensitive info.
There was a problem hiding this comment.
Moving the logs into their own files won't help with early initialization issues, but I think those are less common than problems with the rack configuration or other higher-level things. 👍 to moving foreman logs into their own files and then sending only those along with debug.
Another issue is that the log files may end up being really large in some cases - the debugging output should probably truncate to the last 1k lines or something like that.
There was a problem hiding this comment.
The debug script already truncate all the files and also filters out all
things like "password xyz".
How about taking only *error_log files?
I am fine with creating log files with foreman_ prefix.
Later,
Lukas "lzap" Zapletal
irc: lzap #theforeman
There was a problem hiding this comment.
I'm happy with *error_log, I'm unsure if a Foreman vhost-specific one will catch all Passenger breakage.
There was a problem hiding this comment.
Oh, please add /var/log/apache2 also for Debian.
There was a problem hiding this comment.
So how about this...
Later,
Lukas "lzap" Zapletal
irc: lzap #theforeman
|
👍 |
SSIA I would like to get this into 1.3