Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #32632 - initial verison of Ubuntu autoinstall templates #9076

Merged
merged 1 commit into from Mar 1, 2022

Conversation

lzap
Copy link
Member

@lzap lzap commented Feb 1, 2022

This adds slightly modified and corrected templates which were contributed by @langesmalle

I have cleaned them up, added partitioning scheme, updated some indentation and few issues. I have not tested them yet as I am busy with 3.2 features. Feel free to merge this so we can gradually improve them. I have updated snapshot mocks and there are now two ubuntu versions: 18 (with traditional installer) and 20 (with autoinstall cloud-init based installer). Both have snapshots and I also added YAML validation when generating snapshots to avoid syntax errors in YAML.

More context:

https://community.theforeman.org/t/autoinstalling-ubuntu-server-20-04-3-from-the-live-iso/27050

@theforeman-bot
Copy link
Member

Issues: #32632

Signed-off-by: Lukas Zapletal <lzap+git@redhat.com>
@lzap lzap force-pushed the ubuntu-autoinstall-temps-32632 branch from 7c3b5fe to d281f5d Compare February 9, 2022 18:25
@lzap
Copy link
Member Author

lzap commented Feb 9, 2022

Incorporated latest changes, fixed Rubocop, this is UNTESTED but please let's merge so the community can take it from here. Autoinstall is a new feature that is requested quite a lot, no regressions possible as this is a new template set.

@lzap
Copy link
Member Author

lzap commented Mar 1, 2022

Can we merge this? @ezr-ondrej there is no danger of regressions these are just new templates.

Copy link
Member

@ezr-ondrej ezr-ondrej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no harm in this 👍

@ezr-ondrej ezr-ondrej merged commit 749e7f2 into theforeman:develop Mar 1, 2022
@MariaAga MariaAga added the Needs cherrypick This should be cherrypicked to the stable branches or branches label Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs cherrypick This should be cherrypicked to the stable branches or branches Needs testing Templates
Projects
None yet
4 participants