fixes #2975 added setting for using the shortname instead of FQDN for new VMs

[cyberkov]

Hello!

I made a setting for using the shortname when creating new machines. Unfortunately our test vsphere cluster is currently down so I cannot test it.

If someone tries to provision a hostname twice the error from the virtualization should be passed on, on which Foreman refuses the creation. I therefore haven't implemented any error handling (hope I'm right :) ).

Cheers
Hannes

[domcleal]

It very nearly worked :) I just had to change "SETTINGS" to "Setting" (one refers to settings.yaml, the other to the settings in the database). Your assumption about error handling was certainly correct on libvirt, I'd expect if a given CR is unable to handle duplicate names that it'll throw an error during orchestration and we'll roll back automatically.

Thanks for the patch @cyberkov, merged as a9b9661 for Foreman 1.4.