Fixes #34381 - Change example for --order #9085
Conversation
|
Issues: #34381 |
ofedoren
changed the title
|
@ofedoren do you wanna take this one? :) |
|
@ezr-ondrej, of course, forgot to assign myself. |
There was a problem hiding this comment.
Thanks, @adiabramovitch! LGTM.
Could you please open a CP against 3.1-stable?
|
CP 3.1: 9d3e3d3 |
| @@ -18,7 +18,7 @@ class BaseController < Api::BaseController | |||
|
|
|||
| def_param_group :search_and_pagination do | |||
| param :search, String, :desc => N_("filter results") | |||
| param :order, String, :desc => N_("Sort and order by a searchable field, e.g. 'id DESC'") | |||
| param :order, String, :desc => N_("Sort and order by a searchable field, e.g. '<field> DESC'") | |||
There was a problem hiding this comment.
@ofedoren, @adiabramovitch I believe this is parsed by Maruku and it complains quite loudly:
| Maruku tells you:
+---------------------------------------------------------------------------
| Maruku cannot parse this block of HTML/XML:
| |<field> DESC'
| Missing end tag for 'field' (got 'html')
| Line: 4
| Position: 172
| Last 80 unconsumed characters:
+---------------------------------------------------------------------------
!/home/oezr/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/maruku-0.7.3/lib/maruku/helpers.rb:72:in `rescue in md_html'
!/home/oezr/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/maruku-0.7.3/lib/maruku/helpers.rb:67:in `md_html'
!/home/oezr/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/maruku-0.7.3/lib/maruku/input/parse_span.rb:513:in `read_inline_html'
!/home/oezr/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/maruku-0.7.3/lib/maruku/input/parse_span.rb:115:in `read_span'
\___________________________________________________________________________
Wrapping bad html in a PRE with class 'markdown-html-error'
|<field> DESC'
There was a problem hiding this comment.
Well, we have bunch of these already anyway :/
There was a problem hiding this comment.
well... this is the only one I have in my develop setup currently.
Isn't there a way to escape this for Maruku not to read it as HTML tag?
There was a problem hiding this comment.
Honestly, didn't look at this yet :/ We have a redmine issue [1] to track such warnings.
No description provided.