-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #34710 - Use foreman request address #9171
Conversation
sbernhard
commented
Apr 1, 2022
- Next-server in windows iPXE default template does only work in dhcp environments but not with static IPs
- A method which only returns the request address (fqdn + port) of foreman or the related smart proxy is often useful
Issues: #34710 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @sbernhard, seems OK to me, just few nitpicks. Also,
Next-server in windows iPXE default template does only work in dhcp environments but not with static IPs
Does this change effect working in DHCP environments?
Thank you very much for your review and your comments. I added them.
It should but let me ask my colleagues again. |
Hello, the change will only effect working in DHCP, if you want to use another server than foreman or proxy as next server and want strictly to set this via DHCP and not an extra variable. So normally it has no negativ effect for DHCP scenarios |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @sbernhard and @SimonLorentz. 🟢 from me, but I'd leave it a bit for another pair of eyes in case I missed something :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart of confusing name, and possible imporovements on the docs, LGTM 👍
I'll leave up to @ofedoren to judge if those improvements are worth while :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @sbernhard, @ezr-ondrej, merging :)